New Opera Forums launched

julianlam

julianlam @amatczak

@amatczak @burnout426 This is now resolved:

https://github.com/NodeBB/NodeBB/issues/6027

barisu

barisu

Hi guys,

Baris from NodeBB here, glad to see Opera is using NodeBB!

We just fixed the issue with the reply notification email not pointing to the correct post. https://github.com/NodeBB/NodeBB/issues/6027. It will be available in our next release.

If you discover more issues feel free to open issues on our github tracker. https://github.com/NodeBB/NodeBB/issues

Thanks.

burnout426

burnout426 Volunteer @julianlam

@julianlam @barisu

Thanks very much!

I looked at the diff too to see how you fixed it. Is there a list of supported template variables somewhere?

barisu

barisu @burnout426

@burnout426 not everything is available everywhere, for this particular email template the available variables are here https://github.com/NodeBB/NodeBB/blob/master/src/topics/follow.js#L256-L265. Some common variables are passed to all email templates those are listed here https://github.com/NodeBB/NodeBB/blob/master/src/emailer.js#L89-L97

burnout426

burnout426 Volunteer @barisu

@barisu Thanks.

burnout426

burnout426 Volunteer

@amatczak Looking at the diff, it looks like a super-safe patch.

burnout426

burnout426 Volunteer @emniss

@emniss said in New Opera Forums launching soon!:

Opening a new topic shouldn't be enabled on the subcategories page of "Opera for computers":

https://forums.opera.com/category/5/opera-for-computers

That's looking like a mess.

It is weird / different. If anything, I'd expect it to just be all the threads from the subcategories mixed together.

However, it's not a big deal for me and the current way it's set up is fine with me.

amatczak

amatczak Opera @burnout426

@burnout426 said in New Opera Forums launching soon!:

@amatczak Looking at the diff, it looks like a super-safe patch.

Applied manually already. Tell me if it works

burnout426

burnout426 Volunteer @amatczak

@amatczak Looks like it works so far. I'll test more on a notification for a post that isn't the last post in the thread though and let you know.

burnout426

burnout426 Volunteer @amatczak

@amatczak said in New Opera Forums launching soon!:

@burnout426 Yes, we're aware of that - redesigned email templates were only introduced less than a week before the roll-out, with 1.6.0 upgrade of NodeBB, and we simply didn't have time to style the email template like we'd like. It's on our todo list already. Be sure that after we're done it will look much better (the giant pic on top is a bit of an eyesore indeed )

The default notif_post template has a lot to it. Also, all the HTML comments are emitted in the outgoing email source. So, in playing around with things, I'm starting with this instead:

<!DOCTYPE html>
<html lang="en">
    <head>
        <meta charset="utf-8">
        <title></title>
    </head>
    <body>
        <p>{intro}</p>
        <blockquote><p>{postBody}</p></blockquote>
        <p><a href="{url}/post/{pid}">Click here to read the full reply</a>.</p>
        <p>[[email:closing]]</p>
        <p>{site_title}</p>
        <p>[[email:notif.post.unsub.info]] <a href="{url}/user/{userslug}/settings">[[email:unsub.cta]]</a>.</p>
    </body>
</html>

In the source of the outgoing message, there will be a style tag added above the doctype by the emoji plug-in. I turn it off and restart the server before testing to make sure the markup in the source of the outgoing mail is correct.

In short, it might make sense to start with a simple template and go from there; adding back anything (like some of the meta tags) if needed.

julianlam

julianlam @burnout426

@burnout426 Just so you know, all the boilerplate is there for a reason:

http://tedgoas.github.io/Cerberus/

burnout426

burnout426 Volunteer @julianlam

@julianlam Thanks. Will take a look.

Edit: Read it. Interesting. A lot of workarounds for clients.

burnout426

burnout426 Volunteer @julianlam

@julianlam said in New Opera Forums launching soon!:

@burnout426 Just so you know, all the boilerplate is there for a reason:

http://tedgoas.github.io/Cerberus/

I see the reason for the use of:

<meta name="viewport" content="width=device-width">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="x-apple-disable-message-reformatting">

, the use of CSS (media queries and such) in STYLE, and the use of inline styles for clients that don't use (or strip out) STYLE tags. But, is it really necessary to use TABLE and CENTER to lay out everything, especially for a simple notification email?

I'm not really thinking Table vs. CSS (although the latter would be preferable). Just thinking all that table markup is a lot of noise for a simple notification email.

That's just all on the side though. The actual problem in NodeBB is the big image at the top of the email. Getting rid of the image and the black space above it would make things so much better.

amatczak

amatczak Opera @burnout426

@burnout426 said in New Opera Forums launching soon!:

The actual problem in NodeBB is the big image at the top of the email. Getting rid of the image and the black space above it would make things so much better.

Yes, as said earlier - we are in the process of writing our own, branded templates. The header is definitely going to be slimmer.

But I am sure our friends from NodeBB team are also interested in feedback about the default ones

burnout426

burnout426 Volunteer @amatczak

@amatczak said in New Opera Forums launching soon!:

But I am sure our friends from NodeBB team are also interested in feedback about the default ones

Yes, that was my intent with the post.

A Former User @burnout426

@burnout426 said in New Opera Forums launching soon!:

That's just all on the side though. The actual problem in NodeBB is the big image at the top of the email. Getting rid of the image and the black space above it would make things so much better.

The "black space" is actually where the headers are, black text on a black background, as you can see if you select it!

burnout426

burnout426 Volunteer @Guest

@davehawley Can't confirm. What mail client?

A Former User @burnout426

@burnout426
It's a rather ancient copy of Eudora!
I think in other clients the black band does not include the headers and is therefore not as wide.

alt text

burnout426

burnout426 Volunteer @Guest

@davehawley Ah, I see.

burnout426

burnout426 Volunteer @amatczak

@amatczak Yes, after testing for a while, the link in notification emails does indeed work correctly where it navigates to the correct post.